adds check for fieri feature when displaying quality metrics through api

Signed-off-by: Nell Shamrell <[email protected]>

src/supermarket/app/views/api/v1/cookbook_versions/_cookbook_version.json.jbuilder

@@ -5,7 +5,7 @@ json.average_rating nil
 json.cookbook api_v1_cookbook_url(cookbook)
 json.file api_v1_cookbook_version_download_url(cookbook_version.cookbook, cookbook_version)
 
-if !@cookbook_version_metrics.nil? && @cookbook_version_metrics.any?
+if ROLLOUT.active?(:fieri)
   json.quality_metrics @cookbook_version_metrics do |metric|
     json.name metric.quality_metric.name
     json.failed metric.failure

src/supermarket/spec/api/cookbook_version_spec.rb

@@ -101,23 +101,39 @@
         expect(signature(json_body)).to include(cookbook_version_signature)
       end
 
-      it 'returns quality metrics for the cookbook version' do
-        get json_body['versions'].find { |v| v =~ /0.1.0/ }
-        expect(signature(json_body)).to include(quality_metrics)
-      end
-
-      context 'when the cookbook has only the foodcritic metric' do
+      context 'when the fieri feature is active' do
         before do
-          collab_result.destroy
-          expect(cookbook_version.metric_results.count).to eq(1)
+          allow(ROLLOUT).to receive(:active?).with(:fieri).and_return(true)
         end
 
-        it 'returns a 200' do
+        it 'returns quality metrics for the cookbook version' do
           get "/api/v1/cookbooks/#{cookbook.name}/versions/#{cookbook_version.version}"
+          expect(JSON.parse(response.body)).to include(quality_metrics)
+        end
+
+        context 'when the cookbook has only the foodcritic metric' do
+          before do
+            collab_result.destroy
+            expect(cookbook_version.metric_results.count).to eq(1)
+          end
+
+          it 'returns a 200' do
+            get "/api/v1/cookbooks/#{cookbook.name}/versions/#{cookbook_version.version}"
 
-          expect(response.status.to_i).to eql(200)
+            expect(response.status.to_i).to eql(200)
+          end
+        end
+      end
+
+      context 'when the fieri feature is not active' do
+        before do
+          allow(ROLLOUT).to receive(:active?).with(:fieri).and_return(false)
         end
 
+        it 'does not return quality metrics for the cookbook version' do
+          get "/api/v1/cookbooks/#{cookbook.name}/versions/#{cookbook_version.version}"
+          expect(JSON.parse(response.body)).to_not include(quality_metrics)
+        end
       end
     end