Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devsetup-instructions updated #1099

Merged
merged 2 commits into from
Jan 13, 2023
Merged

devsetup-instructions updated #1099

merged 2 commits into from
Jan 13, 2023

Conversation

kanad-progress
Copy link
Contributor

Signed-off-by: Kanad Kumar [email protected]

Description

Briefly describe the new feature or fix here


Maintainers

Please ensure that you check for:

  • If this change impacts git cache validity, it bumps the git cache
    serial number
  • If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

README.md Outdated
Comment on lines 282 to 285
1. For `development environment` setup update
omnibus.rb [with base_dir './local'] , update /config/projects/$MY_PROJECT_NAME.rb
[need to specify dependency which is just created in software folder]
[exam: $MY_PROJECT_NAME-zlib.rb ], update install_dir with "/tmp/#{name}".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. For `development environment` setup update
omnibus.rb [with base_dir './local'] , update /config/projects/$MY_PROJECT_NAME.rb
[need to specify dependency which is just created in software folder]
[exam: $MY_PROJECT_NAME-zlib.rb ], update install_dir with "/tmp/#{name}".
1. Update software dependencies listed in the project configuration in `config/projects/$MY_PROJECT_NAME.rb`. You can refer the software `.rb` files present in the `config/software` folder.
1. The `install_dir` specified in the project file typically requires `root` privilege at build time. Change it another location such as `"/tmp/#{name}"` to avoid running as `root`.

README.md Show resolved Hide resolved
@vkarve-chef vkarve-chef added Expeditor: Skip All Used to skip all merge_actions. Aspect: Documentation How do we use this project? labels Jan 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vkarve-chef vkarve-chef marked this pull request as ready for review January 13, 2023 05:50
@kanad-progress kanad-progress merged commit c66e97c into main Jan 13, 2023
@kanad-progress kanad-progress deleted the devsetup-instructions branch January 13, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Documentation How do we use this project? Expeditor: Skip All Used to skip all merge_actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants