Allow options to be specified to git_cmd

Allows, for example, the commit message to be more interestingly generated. Signed-off-by: Richard Clamp <[email protected]>
chef · Mar 14, 2018 · 819a35d · 819a35d
1 parent b295322
commit 819a35d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/omnibus/git_cache.rb b/lib/omnibus/git_cache.rb
@@ -195,15 +195,15 @@ def remove_git_dirs
     #
     # @return [Mixlib::Shellout] the underlying command object.
     #
-    def git_cmd(command)
+    def git_cmd(command, opts = {})
       shellout!([
         "git",
         "-c core.autocrlf=false",
         "-c core.ignorecase=false",
         "--git-dir=\"#{cache_path}\"",
         "--work-tree=\"#{install_dir}\"",
         command,
-      ].join(" "))
+      ].join(" "), opts)
     end
 
     #

diff --git a/spec/unit/git_cache_spec.rb b/spec/unit/git_cache_spec.rb
@@ -244,16 +244,22 @@ module Omnibus
         allow(project).to receive(:install_dir)
           .and_return(terrible_install_dir)
         allow(ipc).to receive(:shellout!)
-          .with(%Q{git #{git_flags} version})
+          .with(%Q{git #{git_flags} version}, {})
           .and_return("git version 2.11.0")
       end
 
       it "doesn't mangle an #install_dir with spaces" do
         expect(ipc.send(:install_dir)).to eq(terrible_install_dir)
         expect(ipc).to receive(:shellout!)
-          .with(%Q{git #{git_flags} version})
+          .with(%Q{git #{git_flags} version}, {})
         ipc.send(:git_cmd, "version")
       end
+
+      it "passes options" do
+        expect(ipc).to receive(:shellout!)
+          .with(%Q{git #{git_flags} commit -F -}, input: "Commit message")
+        ipc.send(:git_cmd, "commit -F -", input: "Commit message")
+      end
     end
   end
 end