Improvements to filesystem and wpar detection on AIX #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,7 @@ | |||
| # | |||
| # Author:: Joshua Timberman <[email protected]> | |||
| # Copyright:: Copyright (c) 2013, Opscode, Inc. | |||
| # Author:: Isa Farnik (<[email protected]>) | |||
| # Copyright:: Copyright (c) 2015 Chef Software, Inc. | |||
There was a problem hiding this comment.
The existing years still apply so this should be 2013 - 2015
curiositycasualty
force-pushed
the
if/fix-aix-attrs
branch
from
bcaf473
to
9126f46
Compare
|
@curiositycasualty looks like you need to go through and update all the tests, too |
|
Alright, looks like I've got some tests to fix. |
curiositycasualty
force-pushed
the
if/fix-aix-attrs
branch
from
24528e1
to
dac18f9
Compare
curiositycasualty
force-pushed
the
if/fix-aix-attrs
branch
from
dac18f9
to
14f4247
Compare
curiositycasualty
added
Pending Maintainer Review
and removed
Waiting for Contributor Response
labels
|
1 last thing. Is there a reason we have puppet.com all over the tests? |
|
@tas50 fixed |
|
resolved. |
curiositycasualty
force-pushed
the
if/fix-aix-attrs
branch
from
fa0d0f3
to
5285faf
Compare
|
/cc @josephrdsmith @tas50 Commit messages and tests changed. |
tas50
changed the title
curiositycasualty
force-pushed
the
if/fix-aix-attrs
branch
from
5285faf
to
20404cf
Compare
| @@ -17,7 +18,7 @@ | |||
| # | |||
|
|
|||
| Ohai.plugin(:Virtualization) do | |||
| provides "virtualization" | |||
| provides "virtualization", "wpars" | |||
There was a problem hiding this comment.
It doesn't look like you're setting wpars as a top-level attribute. Do you mean "virtualization/wpars"?
| allow(@plugin).to receive(:shell_out).with("uname -L").and_return(mock_shell_out(0, "29 l273pp027", nil)) | ||
| allow(@plugin).to receive(:shell_out).with("uname -W").and_return(mock_shell_out(0, "0", nil)) | ||
| allow(@plugin).to receive(:shell_out).with("lswpar -L").and_return(mock_shell_out(0, @lswpar_L, nil)) | ||
| @plugin.run |
There was a problem hiding this comment.
plugin is available to use here and it has the same three shell_out stubs on it: https://github.com/chef/ohai/blob/if/fix-aix-attrs/spec/unit/plugins/aix/virtualization_spec.rb#L240-L248
You can replace @plugin with plugin and remove 257-261.
collect fs info by device or mountpoint on AIX AIX WPARs have no macaddresses provide proper os_version on AIX provide WPAR info for an LPAR node (AIX) collect AIX hostnames with dashes properly style and credit for AIX plugns PR comment feedback re: license accommodate WPARs in AIX fs plugin avoid phantom CPUs on WPARs in AIX CPU plugin avoid macaddress on WPARs in AIX networking plugin & test hostname right test AIX platform_version right detect WPARs on LPARs (AIX) refactor AIX filesystem AIX fs plugin: mount options as array license update AIX plugins change AIX test hostnames provide "wpars" as a child of virtualization on AIX reduse code resuse in AIX virt plugin
curiositycasualty
force-pushed
the
if/fix-aix-attrs
branch
from
ea9d23f
to
2434cb9
Compare
|
👍 |
|
👍 Are we ready to merge this? |
|
LGTM |
tas50
added a commit
that referenced
this pull request
Dec 10, 2015
Improvements to filesystem and wpar detection on AIX
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that's everything from my shortlist.
/cc @chef/engineering-services @chef/client-aix