Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version detection in windows #16 #21

Closed
wants to merge 1 commit into from

Conversation

dissonanz
Copy link

No description provided.

@schisamo
Copy link
Contributor

schisamo commented Nov 3, 2015

Looks reasonable to me. Can you give things a review @Patrick-Wright @sersut @jaym?

@jaym
Copy link
Contributor

jaym commented Nov 4, 2015

👍

@wrightp
Copy link

wrightp commented Nov 4, 2015

@thommay Could you please review this change before we merge?

@thommay
Copy link
Contributor

thommay commented Nov 6, 2015

👍

1 similar comment
@mwrock
Copy link
Member

mwrock commented Dec 4, 2015

👍

@sersut
Copy link
Contributor

sersut commented Dec 8, 2015

Thanks @dissonanz. 👍

One thing to keep in mind is that we have moved the logic that uses these files under Mixlib::Install::ScriptGenerator since 0.8.0.alpha.0 release. I wonder if this is a blocker for many @thommay. In that case we should probably release a 0.7.1. Otherwise we will get this out with the next alpha release of 0.8.0 which will eventually become 1.0.0 when we finish our rehaul.

Let us know your thoughts on releasing this @thommay / @dissonanz.

@thommay
Copy link
Contributor

thommay commented Dec 9, 2015

hm, we should probably release this as a 0.7.1 I suppose - but I don't know how much this is affecting people.

@cheeseplus
Copy link

+1

@wrightp
Copy link

wrightp commented Jan 19, 2016

This patch was applied to a branch from the 0.7.0 release. 0.7.1 is tagged, and has been published to rubygems.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants