OC-11565 Add support for parameter --user-data during server create for knife-cloud #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it "doesn't set user data in server_def if user_data not specified" do | ||
| @instance.service = double | ||
| @instance.service.should_receive(:create_server_dependencies) |
There was a problem hiding this comment.
Is this just a stub? It looks like this method is empty in Chef::Knife::Cloud::Service#create_server_dependencies and does not exist in Chef::Knife::Cloud::OpenstackService. Something like this might be more informative and combine these two lines:
@instance.service = double("Chef::Knife::Cloud::OpenstackService", :create_server_dependencies => nil)
| @instance.service = double | ||
| @instance.service.should_receive(:create_server_dependencies) | ||
| @instance.before_exec_command | ||
| @instance.create_options[:server_def].should_not include(:user_data) |
muktaa
pushed a commit
that referenced
this pull request
Apr 28, 2014
OC-11565 Add support for parameter --user-data during server create for knife-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBI Ref:https://tickets.corp.opscode.com/browse/OC-11565
@kaustubh-d @muktaa