OC-9368 Image_os_type option should be compulsory in knife-openstack. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2013 16:33
…enstack and rspec tests for same change
| @@ -115,6 +115,9 @@ def validate_params! | |||
| else | |||
| errors << "You must provide a valid bootstrap protocol. options [ssh/winrm]. For linux type images, options [ssh]" | |||
| end | |||
|
|
|||
| errors << "You must provide --image-os-type option [windows/linux]" if ! (%w(windows linux).include?(locate_config_value(:image_os_type))) | |||
There was a problem hiding this comment.
This check should go in knife-cloud.
The image_os_type field is compulsory for all - but it needs to be entered explicitly by the user of openstack.
For other plugins, we must set it programatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes to make image_os_type compulsory.
Please review.
Thanks!