KNIFE-494 add options for secret and secret_file to support encrypted data bags #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to get some unit tests in here to ensure this functionality doesn't get lost, similar to knife-ec2/c28939. But looks 👍. @mattray ? |
| ui.warn(<<-WARNING) | ||
| Specifying the encrypted data bag secret key using an 'encrypted_data_bag_secret' | ||
| entry in 'knife.rb' is deprecated. Please see CHEF-4011 for more details. You | ||
| can supress this warning and still distribute the secret key to all bootstrapped |
There was a problem hiding this comment.
I realize you copied this from another file, but suppress is the correct spelling and would be good to fix.
|
My bad on the misspelling. I've corrected it. |
mattray
pushed a commit
that referenced
this pull request
Jun 24, 2014
KNIFE-494 add options for secret and secret_file to support encrypted data bags
|
This is included in knife-cloud, I believe we're close to a knife-openstack based on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using encrypted data bags, the current plugin uses the soon to be deprecated encrypted_data_bag_secret and encrypted_data_bag_secret_file options. This patch updates knife openstack server create to use the same functionality as knife bootstrap. Also it allows for command line switches to use this functionality instead of having to embed it in the knife.rb file.
The warning included was copied directly out of knife bootstrap.