KNIFE-477: Delete server by name if instance_id isn't found #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,22 @@ def initialize(options = {}) | |||
| def add_api_endpoint | |||
| @auth_params.merge!({:openstack_auth_url => Chef::Config[:knife][:api_endpoint]}) unless Chef::Config[:knife][:api_endpoint].nil? | |||
| end | |||
|
|
|||
| def get_server(search_term) | |||
| if server = connection.servers.get(search_term) | |||
There was a problem hiding this comment.
servers.get(search_term) might raise some exceptions which needs to be handled here. Plus you are overriding the get_server(arg) method from fog/service.rb here. If you are overriding on purpose then you can use some exception handling except( Excon::Errors::BadRequest ) or you can rename the method.
https://github.com/opscode/knife-cloud/blob/master/lib/chef/knife/cloud/fog/service.rb#L137
kaustubh-d
added a commit
that referenced
this pull request
Jun 2, 2014
[knife-cloud] KNIFE-477: Delete server by name if instance_id isn't found
tas50
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses knife-cloud change: chef/knife-cloud#67
@kaustubh-d