Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop to 0.83 #87

Merged
merged 1 commit into from
May 11, 2020
Merged

Update RuboCop to 0.83 #87

merged 1 commit into from
May 11, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented May 11, 2020

Fixes a giant pile of bugs including a few that impacted cookbooks
Adds autocorrection to a few cops including the issues with ambiguous operators that was painful in cookbooks

Signed-off-by: Tim Smith [email protected]

@tas50 tas50 requested review from a team as code owners May 11, 2020 23:15
@tas50
Copy link
Contributor Author

tas50 commented May 11, 2020

There were no new warnings in chef/chef from this update.

Copy link

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the RUBOCOP_VERSION in cookstyle so we only need 1 version of Rubocop in Workstation 👍

@tas50 tas50 merged commit d6fa7a8 into master May 11, 2020
@chef-expeditor chef-expeditor bot deleted the bump_rubocop_83 branch May 11, 2020 23:42
@tas50
Copy link
Contributor Author

tas50 commented May 11, 2020

sadly we have to bump chefstyle every time we bump cookstyle and they keep fixing my bugs so I've been aggressive with bumping cookstyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants