Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override to_h to call to_hash method. #79

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

mikenairn
Copy link
Contributor

Fixes an issue where to_h returns nil instead of a hash.

irb(main):003:0> require 'cheffish'
irb(main):004:0> mc = Cheffish::MergedConfig.new
irb(main):005:0> mc.to_h
=> nil
ruby --version
ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin12.5.0]

Prevents aws local balancer creation from working properly https://github.com/chef/chef-provisioning-aws/blob/master/lib/chef/provisioning/aws_driver/driver.rb#L123

@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@chef-supermarket
Copy link

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@lamont-granquist
Copy link
Contributor

sort of feel the same way that this should just be a Chef::Mash, but it is super-simple so 👍

@thommay thommay merged commit adee10a into chef:master Dec 6, 2016
@thommay thommay added Bug Type: Bug Does not work as expected. and removed Bug labels Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants