Use appropriate function call for chef 12 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
|
👍 |
|
@jkeiser How's this looking, anything blocking a review? |
|
The code itself looks good, but:
|
|
The problem I was seeing with the 1.9.3 test was: Gem::InstallError: ohai requires Ruby version >= 2.0.0. https://github.com/chef/ohai/blob/master/ohai.gemspec#L16 |
In chef12 the function locate_config_file in Chef::Knife was renamed to chef_config_dir. This patch adds a conditional to check for chef12 and apply the appropriate function call.
|
OK. Will merge and update travis to not run 1.9.3 anymore. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chef12 the function locate_config_file in Chef::Knife was renamed
to chef_config_dir. This patch adds a conditional to check for chef12
and apply the appropriate function call.