Silence deprecation warnings #7375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deprecation warnings. Signed-off-by: Noah Kantrowitz <[email protected]>
…ven if they don't have a docs page. Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
…ome day. Signed-off-by: Noah Kantrowitz <[email protected]>
…silenced easily. Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
…CHEF-n form we show in various places. This is because users might not actually know the deprecation key, so this is probably more approachable. Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
coderanger
requested review from
thommay,
lamont-granquist,
robbkidd,
cheeseplus,
tas50 and
a team
Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
Deprecation CHEF-18 from /Users/coderanger/src/chef/spec/support/shared/integration/knife_support.rb:104:in `block in knife' Starting local-mode server in deprecated socket mode Please see https://docs.chef.io/deprecations_local_listen.html for further details and information on how to correct this problem. Signed-off-by: Noah Kantrowitz <[email protected]>
Signed-off-by: Noah Kantrowitz <[email protected]>
thommay
suggested changes
Jun 15, 2018
| def target | ||
| "internal_api.html" | ||
| end | ||
| target 0 |
There was a problem hiding this comment.
I think we need to preserve the page links for all of these, don't we?
There was a problem hiding this comment.
They are filled in by the default for all except the one non-standard case.
lamont-granquist
approved these changes
Jun 15, 2018
thommay
approved these changes
Jun 18, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a minor overhaul of the deprecation system because it was kind of all over the place.