Bring in the windows_feature_powershell improvements from the cookbook #7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Smith <[email protected]>
This gives us a 3.5x speedup. Yes we need to do this better, but it's no worse than DISM which we already landed in chef and does the exact same thing Signed-off-by: Tim Smith <[email protected]>
tas50
changed the title
lamont-granquist
approved these changes
Apr 2, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to do this better with the singleton, but at the moment this is the exact same method we landed in the dism resource. It's also 3.5x faster than the old method and has behavior changes that landed in the major release of the windows cookbook. We need to make sure those are consistent.
Does it need to be rewritten to not use the node? Yep.