Cleanup to some of the resource specs #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert everything to let and update the tense Nothing real magical here, but gets us one step closer to uniformity in the specs Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
|
two legit travis fails but otherwise 👍 |
The alias tests I added don't actually work, but everything was in linux only so I didn't notice. Move the things out of linux only that can run on any platform and remove the alias tests for now. Signed-off-by: Tim Smith <[email protected]>
tas50
added
Expeditor: Skip Build
Expeditor: Skip Version Bump
chef-ci
pushed a commit
that referenced
this pull request
Dec 19, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
tas50
added
Expeditor: Skip Omnibus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand some of the resource specs to test inputs, actions, and name properties, while not testing the resource class which we just defined in the let block
Remove usage of "should" to make rspec folks happy
Convert before -> let for the resources
Add a few missing package specs