Revert "add missing functional tests for users" #6588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
force-pushed
the
lcg/test-revert
branch
from
0e4d477 to
7e74fad
Compare
This reverts commit fa6e4e8.
lamont-granquist
force-pushed
the
lcg/test-revert
branch
from
7e74fad to
037355c
Compare
lamont-granquist
changed the title
lamont-granquist
changed the title
btm
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
I spent some time debugging this and found that the functionality we are testing here is broken. That doesn't explain to me why this would cause other tests to fail, yet, but I'd support reverting this until I can fix the feature it is testing.
To make support for passing credentials to remote_file we changed to using LOGON32_LOGON_NEW_CREDENTIALS from LOGON32_LOGON_NETWORK, but LOGON32_LOGON_NEW_CREDENTIALS is described as:
This logon type allows the caller to clone its current token and specify new credentials for outbound connections.
Which means we're not actually replacing the token in this case, so we still have an elevated token.
|
Yep, sounds good to me. |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing to see if appveyor goes green or not.
so somewhere between v13.5.28 and v13.6.7 we broke appveyor.
looks like it was fa6e4e8