fix password property is sensitive for mount resource

[dimsh99]

Signed-off-by: dmitrys [email protected]

Description

Password properties become sensitive by default

Issues Resolved

#4850

Check List

• New functionality includes tests
• All tests pass
• RELEASE_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)
• All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

[coderanger]

Not a fan of this approach. It's cute but too much magic for me to be in Chef core. 4850 should be fixed in the mount resource itself IMO.

[coderanger]

To expand, keying this off the name is not super robust. If a property was named user_password, for example, or if the code isn't written in English. It's not a bad assumption but it's overly narrow and we can't possibly parse all human-readable names into secret and not-secret. Better to use the existing explicit API of property(:password, sensitive: true).

[lamont-granquist]

pretty sure we're following that pattern of marking the password property as sensitive on an individual resource now somewhere as well...

it looks like i was the one that mentioned doing this globally and that was probably not one of my best ideas...

[lamont-granquist]

execute.rb: property :password, String, sensitive: true

[lamont-granquist]

remote_file.rb: property :remote_password, String, sensitive: true

[coderanger]

This also makes the username property be sensitive, is that needed?

[dimsh99]

It doesn't make it sensitive, but it's my mistake made while removing old :password definition. I'm really sorry for that.

[coderanger]

lgtm thanks :)

[thommay]

This is a great addition, thank you!