-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn (v. info) when reloading resources #4344
Conversation
e01b9d5
to
34504ab
Compare
yeah this should be debug level, chefspec normally does this from run-to-run and its meaningless. |
Move to debug and it's got my 👍 |
766044d
to
fbe207b
Compare
@lamont-granquist @smurawski Now with more debug! |
@curiositycasualty you're gonna want to fix the tests, too! :) |
looks better 👍 |
tests for debug messages when reloading resources
c5d258e
to
f822e4d
Compare
@thommay Now with more tests! |
👍 ship it! |
Wunderbar! 👍 |
Warn (v. info) when reloading resources
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. Non-GitHub Verified CommittersThere are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute. |
@cwebberOps ^? This PR was closed in January.. |
@curiositycasualty I think there is some work being done on Curry. Not entirely sure what happened. |
These tally up pretty fast. I'd prefer they weren't on the default log level: