Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn (v. info) when reloading resources #4344

Merged
merged 1 commit into from
Jan 13, 2016
Merged

Conversation

curiositycasualty
Copy link
Contributor

These tally up pretty fast. I'd prefer they weren't on the default log level:

[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/chef_handler/providers/default.rb from cookbook chef_handler has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/chef_handler/resources/default.rb from cookbook chef_handler has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/auto_run.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/batch.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/certificate.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/certificate_binding.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/feature_dism.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/feature_powershell.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/feature_servermanagercmd.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/font.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/http_acl.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/pagefile.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/path.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/printer.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/printer_port.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/reboot.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/registry.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/shortcut.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/task.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/providers/zipfile.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/auto_run.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/batch.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/certificate.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/certificate_binding.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/feature.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/font.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/http_acl.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/pagefile.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/path.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/printer.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/printer_port.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/reboot.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/registry.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/shortcut.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/task.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/windows/resources/zipfile.rb from cookbook windows has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/dmg/providers/package.rb from cookbook dmg has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/dmg/resources/package.rb from cookbook dmg has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/yum/providers/globalconfig.rb from cookbook yum has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/yum/providers/repository.rb from cookbook yum has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/yum/resources/globalconfig.rb from cookbook yum has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/yum/resources/repository.rb from cookbook yum has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/git/providers/config.rb from cookbook git has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/git/resources/config.rb from cookbook git has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/homebrew/providers/cask.rb from cookbook homebrew has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: LWRP provider /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/homebrew/providers/tap.rb from cookbook homebrew has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/homebrew/resources/cask.rb from cookbook homebrew has already been loaded!  Skipping the reload.
[2015-12-28T22:34:18-08:00] INFO: Custom resource /var/folders/1k/xm6r9n6d26b63qsh0m6nlz6m0000gn/T/d20151228-11523-mvxs61/cookbooks/homebrew/resources/tap.rb from cookbook homebrew has already been loaded!  Skipping the reload.

@curiositycasualty curiositycasualty force-pushed the if/warn-on-reload-resource branch from e01b9d5 to 34504ab Compare December 29, 2015 08:03
@lamont-granquist
Copy link
Contributor

yeah this should be debug level, chefspec normally does this from run-to-run and its meaningless.

@smurawski
Copy link
Contributor

Move to debug and it's got my 👍

@curiositycasualty curiositycasualty force-pushed the if/warn-on-reload-resource branch from 766044d to fbe207b Compare January 12, 2016 20:08
@curiositycasualty
Copy link
Contributor Author

@lamont-granquist @smurawski Now with more debug!

@thommay
Copy link
Contributor

thommay commented Jan 12, 2016

@curiositycasualty you're gonna want to fix the tests, too! :)

@lamont-granquist
Copy link
Contributor

looks better 👍

tests for debug messages when reloading resources
@curiositycasualty curiositycasualty force-pushed the if/warn-on-reload-resource branch from c5d258e to f822e4d Compare January 12, 2016 20:51
@curiositycasualty
Copy link
Contributor Author

@thommay Now with more tests!

@smurawski
Copy link
Contributor

👍 ship it!

@thommay
Copy link
Contributor

thommay commented Jan 13, 2016

Wunderbar! 👍

thommay added a commit that referenced this pull request Jan 13, 2016
Warn (v. info) when reloading resources
@thommay thommay merged commit e42f1c3 into master Jan 13, 2016
@curiositycasualty curiositycasualty deleted the if/warn-on-reload-resource branch January 13, 2016 19:31
@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

@curiositycasualty
Copy link
Contributor Author

@cwebberOps ^? This PR was closed in January..

@cwebberOps
Copy link
Contributor

@curiositycasualty I think there is some work being done on Curry. Not entirely sure what happened.

@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants