GH-1909 Add validation for chef_server_url #3810

skmichaelson · 2015-08-21T17:48:31Z

No description provided.

chef-supermarket · 2015-08-21T17:48:35Z

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

thommay · 2015-09-15T17:07:45Z

Hi @skmichaelson, to progress further with this PR we'll need to ask you to sign a CLA.

skmichaelson · 2015-09-15T20:03:11Z

@thommay, I signed the ICLA on August 20th. My Chef Supermarket profile says that I'm authorized to contribute:

Is there something else I forgot to do?

thommay · 2015-09-16T10:06:56Z

Ah, the email address that you used to commit the changes isn't linked to your github account. Can you either add the email address to your github account ( https://help.github.com/articles/adding-an-email-address-to-your-github-account/ ) or follow https://help.github.com/articles/setting-your-email-in-git/ to set your email address locally; you'll then need to change your previous commits. I'd achieve this by doing a rebase and squash - https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history is a good guide to this. Thanks!

chef-supermarket · 2015-09-16T11:14:34Z

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

chef-supermarket · 2015-09-16T11:33:33Z

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

chef-supermarket · 2015-09-16T11:37:39Z

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

thommay · 2015-09-17T13:50:33Z

👍

btm · 2015-11-25T17:41:34Z

chef-config/lib/chef-config/config.rb

-    configurable(:chef_server_url).writes_value { |url| url.to_s.strip }
+    configurable(:chef_server_url).writes_value do |uri|
+      unless is_valid_url? uri
+        raise ConfigurationError, "#{url} is an invalid chef_server_url."


s/url/uri/. I'll fix this on merge. 👍

thommay added the Waiting for Contributor Response label Sep 15, 2015

thommay modified the milestones: Accepted Minor, Help Wanted Sep 15, 2015

skmichaelson force-pushed the master branch from f79c169 to 388df7c Compare September 16, 2015 11:14