-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Issue #2513 - the broken render of nested partial templates #3510
Conversation
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. GitHub Users Who Are Not Authorized To ContributeThe following GitHub users do not appear to have signed a CLA: |
Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future. |
Can someone look at this? |
This looks reasonable; 👍 |
Can https://github.com/chef/chef/blob/master/spec/unit/mixin/template_spec.rb be updated with a test for this? |
I'm okay to merge if we need it now to fix the broken, but this really deserves a regression test to ensure it works in the future. |
Can we merge it now to fix the broken template rendering?
|
I added regression testing here: ckaushik#1 @ckaushik will you merge this into your PR? cc/ @tyler-ball, @danielsdeleo |
…s with variables Authors: Kaushik C <[email protected]>, Sam Dunne <[email protected]>
@danielsdeleo does this look good for merging? |
Nice! 👍 |
👍 |
Fixing Issue #2513 - the broken render of nested partial templates
Adding the instance variable @template_finder to the new TemplateContext class for rendering partials