Lcg/zypper package #3477
Merged
Lcg/zypper package #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i'm not sure how anybody has been using this resource, but think we may have broken this in 12.0.0 at some point, at any rate this will make it a lot easier for people to actually use.
|
@chef/client-core this can use some review |
|
👍 Might be interesting to see what happens if you move the provides lines out from package.rb into zypper_package.rb, |
|
👍 |
|
LGTM 👍 |
|
LGTM. Never heard of zypper though :) |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates zypper package to look like the rest of our package classes.