Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_resource_semantics! lifecycle method to provider #3360

Merged
merged 4 commits into from
May 15, 2015

Conversation

jaym
Copy link
Contributor

@jaym jaym commented May 11, 2015

Added a lifecycle method to check if the resource makes sense for the provider. That way, we can fail before loading it. Will add specs if we want to solve the problem this way :)
Fixed #3075 as an example

cc @jaymzh @chef/client-core

@lamont-granquist
Copy link
Contributor

Yeah I guess we need to do this. This should ideally go into the resource, but with the compile/converge mode split and with the possibility of resources being passed lazy {} we can't really do this until provider/converge time.

Yet more ammunition that compile/converge mode needs to go away and Resources and Providers need to be fused together. We're starting to lazy up parameter validation and the Resource can't even do its job properly...

👍 modulo a detour into (getoffmylawn)

@smurawski
Copy link
Contributor

👍 Merge it

@btm
Copy link
Contributor

btm commented May 15, 2015

👍 thanks for cleaning this task up.

jaym added a commit that referenced this pull request May 15, 2015
Add check_resource_semantics! lifecycle method to provider
@jaym jaym merged commit 504161a into master May 15, 2015
@jaym jaym deleted the jdm/resource-semantics branch May 15, 2015 16:35
jaym added a commit that referenced this pull request May 15, 2015
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package resource should not allow multi-package and source to both be specified
7 participants