Remove experimental warning on audit mode.

[juliandunn]

I'm going to suggest we remove this to avoid freaking out customers since we have been shipping this mode for some time.

/cc @chef/analytics-data-integrations

[jaym]

Did we solve the issue around audit mode mangling exceptions?

[juliandunn]

What do you mean by "mangling exceptions"?

[jaym]

625373d#diff-c34d08382bb25f61e44ecbd5f50f4166
This was one of the regressions in 12.2 and we ended up patching it. By making audit mode the default, the people we broke before will break again.

[jaym]

I think the example we got was SystemExit and how this broke people's CI. Not sure if there is anything else that we need to consider.
cc @tyler-ball

[juliandunn]

My PR doesn't make audit mode the default; I don't know that we need to do that right now. I'm just removing warnings here.

[jaym]

My bad, I guess this is harmless then.

[tyler-ball]

@jdmundrawala If audit mode is disabled (the default) we don't wrap any raised exceptions, we just re-raise them - #3090

[tyler-ball]

👍 On this change. I could see people being concerned this message gets changed in a patch version. Can we hold off on it until the next major version (12.4)?

[juliandunn]

@tyler-ball Sure, that's fine

[juliandunn]

Per @tyler-ball's message -- looks like we're on the cusp of releasing 12.4. Can I get this warning removal in there? /cc @chef/client-maintainers

[danielsdeleo]

👍 as long as we're sufficiently confident that the design is fairly stable and we don't need to change it in incompatible ways in the future.

[jtimberman]

The main thing off the top of my head is this

#3482

It's a bug fix but if people did the should syntax in their tests that change would break them.

[juliandunn]

@jtimberman I'm going to argue that whether that's a bug or not doesn't generally change the shape of the design of audit mode, and at this point we've got enough usage & published enough articles about it that we should just say it's shipped.

[danielsdeleo]

Well then you shouldn't break any working code. OTOH, that may be a moot point: #3482 (comment)