Adding back logic to delete the association request when adding a user to an org (as well as adding the user to the groups) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to an org (as well as adding the user to the groups)
|
Given that the tests for this already exist, 👍! Shipit! |
tyler-ball
added a commit
that referenced
this pull request
Aug 20, 2015
Adding back logic to delete the association request when adding a user to an org (as well as adding the user to the groups)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we over-simplified in #146 - adding a user to an org was no longer removing the association request or adding the user to the groups. I think I have fixed this now.
The only reason I caught this was the failures coming from https://github.com/chef/cheffish/blob/17638eec1cee1efd1cd68e4c531d984b5201c214/spec/integration/chef_organization_spec.rb#L145-L153 - cheffish was testing to make sure chef-zero was removing the user from the association when it was added to the org. There was no failing pedant test for this - I need to file a oc-chef-pedant issue to get this covered.
\cc @jkeiser @ssd @marcparadise @andrewjamesbrown