Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GA 4 #2757

Closed
wants to merge 2 commits into from
Closed

Use GA 4 #2757

wants to merge 2 commits into from

Conversation

kagarmoe
Copy link
Contributor

Signed-off-by: kagarmoe [email protected]

Description

Hugo internal templates don't support Google Analytics. This PR attempts to setup the site to use GA4.

  • Adds the gtag javascript in a partial
  • Calls the partial in the appropriate places, (instead of calling the internal template)

See Hugo Issue 7945

Definition of Done

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]

Check List

  • Spell Check
  • Local build
  • Examine the local build
  • All tests pass

Signed-off-by: kagarmoe <[email protected]>
@kagarmoe kagarmoe requested a review from a team as a code owner November 25, 2020 01:14
@netlify
Copy link

netlify bot commented Nov 25, 2020

Deploy preview for chef-web-docs ready!

Built with commit 74b81eb

https://deploy-preview-2757--chef-web-docs.netlify.app

@kagarmoe
Copy link
Contributor Author

Tag change in #2758 worked. We can wait for Hugo to fix the internal template & then switch to GA4.

@kagarmoe kagarmoe closed this Nov 25, 2020
@kagarmoe kagarmoe deleted the kg/feedback-debug branch January 16, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant