Add support for clients #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi |
|
@thommay very nice 😀 I'll make sure to update and finish the PR this week (today or tomorrow most likely), so we can include it in 3.0 👍 |
svanharmelen
force-pushed
the
f-clients
branch
6 times, most recently
from
4fcc726
to
92db56a
Compare
Signed-off-by: Sander van Harmelen <[email protected]>
svanharmelen
force-pushed
the
f-clients
branch
from
92db56a
to
daddf78
Compare
|
@thommay I rebased the PR, added a few tests and updated the README.md and KNIFE-EXAMPLES.md files to represent the changes. So all seems to be good now, but I notice that when I do some functional tests with the current code, I get these errors: ERROR: OpenSSL::PKey::RSAError: Neither PUB key nor PRIV key: nested asn1 errorIs there anything changed that is not backwards compatible? We're using The error is not related to my changes, because I get the same error when using Thx! |
|
Hm, that really doesn't look good. Can you share exactly which steps you're performing, and the output of |
|
@thommay sure, here you go (I included the output of |
|
@thommay guess this should not be a blocker for this PR right? Maybe we should merge this PR and open a separate issue for the error I got? Let me know how you want to proceed... |
|
Yeah. Mind opening that issue? |
|
Sure, will create a new issue in a few... Thx for merging this one! |
|
@thommay Was this included in the release candidate for 3.0.0? Any idea when 3.0.0 will be released? Sorry if this is not the place for this question. |
|
@rneu31 yes it's in the RCs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before finishing up this PR I would like some feedback about the feasibility of getting this functionality merged in
chef-vault?The reason we have a need for this is because we would like the Terraform
chefprovisioner to be able to add single clients in the same way asknife bootstrapcurrently does.knife bootstrapdoes this by directly calling/using thechef-vaultpackage, but that approach is not possible for thechefprovisioner.So currently we add
clientsasadmins, but of course this has all kinds of nasty side effects and is now howchef-vaultshould be used so people are not happy with that approach.Besides this very specific reason, I would imagine that this is adds value by extending the number use cases in which
knife vaultcan be used.I really hope this is something that can be merged as it would make the Terraform
chefprovisioner able to handlechef-vaultscorrectly and with that have better Chef support/integration.EDIT: I know this branch is outdated because I based it of v2.9.0 instead of master. I will of course rebase this if/when we can move forward with this PR!