-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only save keys on refresh operation #194
Conversation
@thommay any thoughs regarding this PR ? |
I think it's fine, but I've not had a chance to test it. I'd also like to see some tests, to confirm that we only write the things we need to write, and to confirm that we do write the right things. |
580d378
to
863648e
Compare
@thommay I've added specs (and rebased against master). |
(closed just to get travis to build it) |
63ff041
to
0596237
Compare
tests are failing except on ruby 1.9.3, I am investigating but I doubt this is linked to this patch. Edit: the features testing fails without my patch.Issue can be tracked down to chef/chef#4602. |
Ok, so I fixed the feature tests :) But sadly your tests are still red. The issue is that |
When doing a refresh, saving the encrypted secret is useless since neither the secret, neither the shared key has changed. Before this patch, the IV was not reused and the encrypted data changed on each refresh operation.
0596237
to
e87c70c
Compare
fixed, thanks for your advices |
Only save keys on refresh operation
Awesome, thanks |
When doing a refresh, saving the encrypted secret is useless since
neither the secret, neither the shared key has changed.
Before this patch, the IV was not reused and the encrypted data changed
on each refresh operation.
This improves partially #193 .