Add proxy support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjasghar
commented
Apr 18, 2017
| @@ -8,6 +9,12 @@ class VsphereHelper | |||
| end | |||
|
|
|||
| def initialize(connect_options, datacenter_name) | |||
| if ENV['https_proxy'] | |||
There was a problem hiding this comment.
@mwrock on Dec 1, 2016 Contributor
I'd do the same with HTTP_PROXY and make https_proxy uppercase which should not matter on windows but will on linux.
Added changes for https and http proxy Signed-off-by: JJ Asghar <[email protected]>
jjasghar
force-pushed
the
rlanore-master
branch
from
40ac9ea
to
debb79d
Compare
jrgarcia
reviewed
Apr 20, 2017
| proxy_uri = URI.parse(ENV['HTTP_PROXY']) | ||
| connect_options[:proxyHost] = proxy_uri.host | ||
| connect_options[:proxyPort] = proxy_uri.port | ||
| when ENV['HTTPS_PROXY_'] |
There was a problem hiding this comment.
I think there may be an extra underscore here (...OXY_']...)
added 2 commits
April 20, 2017 16:13
proxy parsing can be challanging. Signed-off-by: JJ Asghar <[email protected]>
jrgarcia
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add proxy support, with ENV https_proxy, to access Vsphere API
rbvmomi support proxy ( but no proxy pass and user for now ).