Add proxy support #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwrock
suggested changes
Dec 1, 2016
| @@ -8,6 +9,12 @@ class VsphereHelper | |||
| end | |||
|
|
|||
| def initialize(connect_options, datacenter_name) | |||
| if ENV['https_proxy'] | |||
There was a problem hiding this comment.
I'd do the same with HTTP_PROXY and make https_proxy uppercase which should not matter on windows but will on linux.
|
Hi! If you're still interested in getting this merged, please close and reopen this We are in the process of reinvigorating this project and look forward to many collaborations Thanks for your time and help! Oh! We also are on the VMware{Code} slack team in #chef if you'd ever like to come by and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add proxy support, with ENV https_proxy, to access Vsphere API
rbvmomi support proxy ( but no proxy pass and user for now ).