Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm_hostname is set to false in test-kitchen config #189

Closed
btm opened this issue Mar 4, 2015 · 1 comment
Closed

vm_hostname is set to false in test-kitchen config #189

btm opened this issue Mar 4, 2015 · 1 comment

Comments

@btm
Copy link
Contributor

btm commented Mar 4, 2015

sometimes windows images wouldn't come up with an error around setting the hostname, so we set vm_hostname to false. Apparently this is now setting the hostname to false. According to the Vagrant Docs we may want to set that to nil to avoid setting the hostname, but ideally we fix the error.

Best theory right now is vagrant is breaking with long host name. We should figure it out and get it fixed in vagrant.

It looks like currently there's a reboot involved:
https://github.com/mitchellh/vagrant/blob/master/plugins/guests/windows/cap/change_host_name.rb#L10

Vagrant tried to remove the reboot in hashicorp/vagrant#4693 but it caused problems and it was reverted in hashicorp/vagrant#5240.

/cc @cmluciano
btm added a commit that referenced this issue Mar 13, 2015
@btm
Remove vm_hostname:false from .travis.yml - Github Issue #189
732295a 
This was effectively setting the hostname to false for all guests. Which we believe
was helping a bug where kitchen-vagrant/vagrant would fail to set the hostname if it was
over a certain length. Although, I had intended this to make kitchen-vagrant not set a
hostname at all, but apparently to that we needed this value to be nil.

That's the new default in the new-driver-model branch of kitchen-vagrant, which
we should see merged into master and/or windows-guest-support soon.
@btm
Copy link
Contributor Author

btm commented Mar 13, 2015

A while ago test-kitchen/kitchen-vagrant#117 made the hostname set a little shorter by removing ".vagrantup.com" from the set hostname.

@fnichol recently did work that fixes this on the https://github.com/test-kitchen/kitchen-vagrant/tree/new-driver-model branch. As soon as that's in windows-guest-support, we should be great. I've switched over to the windows-guest-support branch for testing in 324ec0a and removed the vm_hostname line in 732295a.

It's possible we'll still have intermittent issues with hostnames until the new-driver-model branch is merged into the windows-guest-support branch.

@btm btm closed this as completed Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@btm