-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache omnibus download, expose config options #73
Cache omnibus download, expose config options #73
Conversation
…ss `-d` to install.sh as the cache dir
…all.sh. The env var still works but has lower precedence
@schisamo build fails due to a bug in rubocop 0.19.1 that is already fixed in master (see rubocop/rubocop#892). I have now pinned rubocop to 0.18.1 in the gemspec to unblock the travis build here. |
Thanks for the PR! Hoping to have some time to get this integrated next week. |
excited for this, especially because I'm commenting from hotel wifi while waiting for omnibus 👍 |
👍 great work 🎆 |
Any idea when there is going to be a release that includes this? I'm stoked to be able to use this! |
👍 Can't wait for this! |
Likewise, I am excited for this to be released! (I just read through a couple github comment threads on this issue/feature.) |
Yes! When is this going to be released?! Looking forward to have my tests speeding up as a result. :) |
👍 Awesome work Humans of Github! My development workflow and sanity thanks you. |
@@ -23,5 +23,5 @@ Gem::Specification.new do |spec| | |||
spec.add_development_dependency 'bundler', '~> 1.3' | |||
spec.add_development_dependency 'rake' | |||
spec.add_development_dependency 'rspec' | |||
spec.add_development_dependency 'rubocop' | |||
spec.add_development_dependency 'rubocop', '0.18.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU! I think that was the last sane version of Rubocop! 😄
…rebased Cache omnibus download, expose config options (rebased)
I messed up history in #71. This one is rebased on master.
Fixes #68
Instead of using an env var the config option
config.omnibus.cache_packages
is introduced. By default it istrue
, so it can be turned off if you don't want the caching behaviour.Additionally the
config.omnibus.install_url
option has been exposed. The$OMNIBUS_INSTALL_URL
is still considered, but has lower precedence than the config option.cache_packages
Caching kicks in only iff:
cache_packages
is truthyconfig.cachier.auto_detect
enabled (which is the default)If caching kicks in
-d /tmp/vagrant-cache/vagrant_omnibus
will be passed toinstall.sh
so this will be the location on the guest to which a) the omnibus package will be downloaded and b) which will be cached by vagrant-cachier.The config option is truthy. Currently we default to
true
, but if more caching strategies would be implemented in the future it could be:cachier
,:something_else
or:whatever
as well. Onlyfalse
ornil
will disable the caching behaviour.install_script
The precedence is now:
config.omnibus.install_url
if setENV['OMNIBUS_INSTALL_URL']
if setThere is some basic validation in place at install time (didn't change anything here). You can pass in for example: