Fixes for chef13 and cheffish5.x/cheffish-13.x #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case (like used with vsphere, for exmple), since MergedConfig only takes hashes, but config is a mash Signed-off-by: Jaymz Julian <[email protected]>
Signed-off-by: Jaymz Julian <[email protected]>
Signed-off-by: Jaymz Julian <[email protected]>
Closed
|
Thanks for this PR! |
bglimepoint
pushed a commit
to bglimepoint/chef-provisioning
that referenced
this pull request
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
driver_for_url needs a to_hash added to its config for the string url case (like used with vsphere, for exmple), since MergedConfig only takes hashes, but config is a mash
resource creation functions no longer take caller
The first of these is actually required for chef12 with cheffish5 as well, the other two commits are chef-13 compatability