Fix issue when checking guest IP of the VM with Docker installed #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
This will absolutely break my environment as is - 172.18.x.x is a valid internal IP set, not just used by docker. Please don't merge as is! :) |
|
If you really do need to filter by IP, maybe add something to bootstrap options as a IP filter list, and then filter based on that - then at least it's something you have to specifically turn on, and you can choose your range. |
|
Thanks @jjlimepoint. Your case "172.18.x.x" makes sense. "add something to bootstrap options as a IP filter list" is a good solution. I will update it later. |
When docker daemon runs in the VM, there will be a NIC created by Docker and usually has IP like 172.17.x.x. When VM is booting up, VM Tools sometimes reports this IP to vCenter, although the real IP of the non-docker nic will be reported later. This patch can filter out the docker IP by specifying the prefix of the invalid machine IP via the bootstrap option 'invalid_ip_prefix'. e.g. invalid_ip_prefix: '172.17'.
jessehu
changed the title
jessehu
changed the title
|
Hi @jjlimepoint , I have updated the patch to use bootstrap options for the IP filter. Please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When docker daemon runs in the VM, there will be a NIC created by
Docker and usually has IP like 172.17.x.x. When VM is booting up,
VM Tools sometimes reports this IP to vCenter, although the real IP
of the non-docker nic will be reported later.
This patch can filter out the docker IP by specifying the prefix of
the invalid machine IP via the bootstrap option 'invalid_ip_prefix'.
e.g. invalid_ip_prefix: '172.17'.