-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use individual lodash functions #864
Conversation
👍 Another consequence of this change is that lodash no longer pollutes the global namespace. I am actually using the react testing library 'enzyme' and it's dependency on 'cheerio' is frustrating for that reason (currently overriding underscore) Would like to see this change merged! :) |
Ping @fb55 @jugglinmike :-) |
IMHO keeping the |
Hm, I can see how that would be ideal. I don't mind doing that—what does @jugglinmike think? |
Sorry for the late PR—been busy. I think I did what you meant, let me know. |
Awesome, thanks a lot :) |
It seems like this change should be done using the |
@ianstormtaylor if @fb55 agrees I don't mind submitting a PR for that. So it'd just be installing lodash fully again but using |
@sotojuan yup, exactly like that! It should mean that other deps using |
👍 We'll see what the repo owners think and I'll implement as needed. |
@sotojuan @ianstormtaylor I implemented the change you suggested in #913. |
May help with #862.
I replaced lodash with individual packages for each function. This brought down the size by ~4mb. Not too bad!