Document, test, and extend static $.text method
#855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `$.root` to return the rendered text content of the current root element when no argument is specified. This increases API parity with the existing static methods `$.html` and``$.xml`. This change technically breaks backwards compatability, but the previous behavior was undocumented and untested.
jugglinmike
force-pushed
the
static-text
branch
from
f9d0e1a to
f050807
Compare
|
|
||
| ```js | ||
| $ = cheerio.load('<div>This is <em>content</em>.</div>') | ||
| cheerio.text($('div')) |
There was a problem hiding this comment.
There could perhaps be a test case for this as well. LGTM otherwise!
|
Merged as 54359c9. Not sure why Github isn't showing it. |
romellem
pushed a commit
to romellem/cheerio
that referenced
this pull request
Jun 13, 2016
* Document and test static `text` method * Extend `$.text()` to operate on current root Update `$.root` to return the rendered text content of the current root element when no argument is specified. This increases API parity with the existing static methods `$.html` and``$.xml`. This change technically breaks backwards compatability, but the previous behavior was undocumented and untested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the commit messages, this method was previously undocumented and untested. Add tests, and implement a change that, while technically backwards-incompatible, promotes parity between this method and the static methods
$.htmland$.xml.