Change lodash dependencies to ^3.2.0 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fb55 any news on when the next version of cheerio will be released ? |
|
? |
fb55
added a commit
that referenced
this pull request
Feb 27, 2015
Change lodash dependencies to ^3.2.0
|
There are some prs I'd like to see merged before publishing a new version (eg. #631 and #647). I'm hesitant to go ahead with them without an okay from @matthewmueller, @jugglinmike or @davidchambers. |
|
@fb55 sorry about those lingering ones--I'll take a look this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I made a PR for this a few days ago (#653). But I think
~3.1.0is too strict considering what cheerio is using from lodash (core methods):_.each,_.forEach,_.map,_.defaultsand_.merge; these methods are not planned to change in the3.x.xor anytime soon.Being less strict is better for people using it with something like browserify (reduce bundle size by avoiding having 2 versions of lodash).
For example, from
3.1.0to3.2.0, jdalton fixed some "important" issues in non-core methods (chaining): lodash/lodash#955 and lodash/lodash#958.Another, maybe better and even less strict, solution can be:
3.x.x || 2.4.xLet me know what you think.