Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(options): Revamp option handling #2916

Merged
merged 4 commits into from
Dec 24, 2022
Merged

refactor(options): Revamp option handling #2916

merged 4 commits into from
Dec 24, 2022

Commits on Dec 23, 2022

  1. refactor(options): Revamp option handling 

    htmlparser2 options have been moved out of the root options for Cheerio, making it more obvious which options will take effect. This currently only affects the TypeScript type.

Users that want to use htmlparser2 should use the `xml` option:

```js
const $ = cheerio.load('<html>', { xml: {
  withStartIndices: true
}})
```
    @fb55
    fb55 committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    957a668 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. Improve comments

    @fb55
    fb55 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    044c619 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into options-revamp

    @fb55
    fb55 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    23da65a View commit details
    Browse the repository at this point in the history

  3. Allow treeAdapter to be overwritten

    @fb55
    fb55 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    bba5389 View commit details
    Browse the repository at this point in the history