Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some tests #1640

Merged
merged 3 commits into from
Jan 4, 2021
Merged

added some tests #1640

merged 3 commits into from
Jan 4, 2021

Conversation

5saviahv
Copy link
Contributor

@5saviahv 5saviahv commented Jan 4, 2021

added/changed some tests so more conditions would be covered

lib/api/traversing.js Outdated Show resolved Hide resolved
@fb55
Copy link
Member

fb55 commented Jan 4, 2021

This looks great! The change in .not reduces consistency and should probably be reverted, otherwise these are some great changes.

@fb55 fb55 merged commit b6d3840 into cheeriojs:main Jan 4, 2021
@fb55
Copy link
Member

fb55 commented Jan 4, 2021

Thanks for following up, and nice patch!

@5saviahv 5saviahv deleted the tests branch January 4, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants