Return undefined in .prop if given an invalid element or tag (#880)

cheeriojs · Jul 4, 2016 · 1d2e8a7 · 1d2e8a7
1 parent df55c93
commit 1d2e8a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/api/attributes.js b/lib/api/attributes.js
@@ -91,6 +91,8 @@ exports.attr = function(name, value) {
 };
 
 var getProp = function (el, name) {
+  if (!el || !isTag(el)) return;
+
   return el.hasOwnProperty(name)
       ? el[name]
       : rboolean.test(name)

diff --git a/test/api/attributes.js b/test/api/attributes.js
@@ -182,6 +182,11 @@ describe('$(...)', function() {
     it('(key, value) : should support chaining after setting props', function() {
       expect(checkbox.prop('checked', false)).to.equal(checkbox);
     });
+
+    it('(invalid element/tag) : prop should return undefined', function() {
+      expect($(undefined).prop('prop')).to.be(undefined);
+      expect($(null).prop('prop')).to.be(undefined);
+    });
   });
 
   describe('.data', function() {