fix(utils): Recognise comments as HTML (#2504)

cheeriojs · Apr 30, 2022 · 16dbf20 · 16dbf20
1 parent 1eaab1a
commit 16dbf20
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/cheerio.spec.ts b/src/cheerio.spec.ts
@@ -443,6 +443,8 @@ describe('cheerio', () => {
       expect(utils.isHtml('<p>fox<p>cat')).toBe(true);
       expect(utils.isHtml('\n<p>fox<p>cat\n')).toBe(true);
       expect(utils.isHtml('#<p>fox<p>cat#')).toBe(true);
+      expect(utils.isHtml('<!-- comment -->')).toBe(true);
+      expect(utils.isHtml('<!doctype html>')).toBe(true);
       expect(utils.isHtml('<123>')).toBe(false);
     });
   });

diff --git a/src/utils.ts b/src/utils.ts
@@ -113,7 +113,8 @@ export function isHtml(str: string): boolean {
 
   return (
     ((tagChar >= 'a' && tagChar <= 'z') ||
-      (tagChar >= 'A' && tagChar <= 'Z')) &&
+      (tagChar >= 'A' && tagChar <= 'Z') ||
+      tagChar === '!') &&
     str.includes('>', tagStart + 2)
   );
 }