Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link #56

Closed
frankbenoit opened this issue Jan 3, 2017 · 4 comments
Closed

Dead link #56

frankbenoit opened this issue Jan 3, 2017 · 4 comments
Assignees
Milestone

Comments

@frankbenoit
Copy link

Hi

the rule "Abbreviation As Word In Name", there is a link to the Google StyleGuide, which is no more working.
You may change the link to point to https://google.github.io/styleguide/javaguide.html

Frank

@romani
Copy link
Member

romani commented Jan 3, 2017

bad link - http://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s5.3-camel-case
.... documentation blocks are out of sync from what we have in main repo ....

we need to do:

  1. fix this link
  2. enforce linkcheck maven plugin on repo to ensure no dead links in that html files.
  3. sync documentation text should be done in separate issue (complex problem)

@romani
Copy link
Member

romani commented Jan 3, 2017

usage of linkcheck plugin is not possiblenow , new feature is requested - https://issues.apache.org/jira/browse/MLINKCHECK-27

Whole link of pages that have link some of them are dead:

~/java/github/checkstyle/sonar-checkstyle/checkstyle-sonar-plugin/src/main/resources/org/sonar/l10n/checkstyle/rules/checkstyle [master|✔] 
$ grep -l "http" *.html
com.puppycrawl.tools.checkstyle.checks.annotation.PackageAnnotationCheck.html
com.puppycrawl.tools.checkstyle.checks.AvoidEscapedUnicodeCharactersCheck.html
com.puppycrawl.tools.checkstyle.checks.design.OneTopLevelClassCheck.html
com.puppycrawl.tools.checkstyle.checks.imports.ImportControlCheck.html
com.puppycrawl.tools.checkstyle.checks.indentation.CommentsIndentationCheck.html
com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck.html
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck.html
com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck.html
com.puppycrawl.tools.checkstyle.checks.UpperEllCheck.html

@romani romani self-assigned this Jan 3, 2017
romani added a commit that referenced this issue Jan 3, 2017
@romani
Copy link
Member

romani commented Jan 3, 2017

all files with links are updated.

All other documentation updates should be done by #57 .

@romani romani closed this as completed Jan 3, 2017
@romani romani added this to the 3.5 milestone Jan 3, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants