-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch-filters doesn't work on Windows OS #352
Comments
@Bananeweizen I have not fully confirmed eclipse-cs yet, but #113 is on the point to being resolved which is this repo's unit tests for Windows. Since eclipse-cs didn't get any exceptions, I am thinking the main culprit for Windows support was #113 (comment) and the slash handling of Audit events. Please also be careful to note #363 as the current behavior of patch-filter in your repo is it won't include unstaged changes. I will provide my report on eclipse-cs in another post, but I wanted to lay out the plan for even eclipse-cs to get this fix if it has been resolved. A plan is needed because patch-filters has already moved to CS 10.4 and I highly recommend sticking to the required version by sevntu which is still 10 otherwise we can't guarantee what will happen, as we have seen before.
|
Patch Filters:
Change in Eclipse-CS:
I am satisfied that the changes under #113 resolve this issue. |
What I can say is that the exceptions in the patch-filters unit tests are definitely gone for me. Beyond that, the Locale issue that we just discussed in the main project stops me from confirming that it works. But I have trust in you solving it fully. |
Correct. I provided results at #352 (comment) that it works as reported. |
Released in 1.4.0 |
@Bananeweizen , are you ok to try #363 (comment) in this repo ? |
Are you asking, whether I would run the command for adding the files from that comment manually on changes? If so, no. I know that I would forget this all the time, since I don't even use the command line for my git operations (I use egit). |
Identified at checkstyle/eclipse-cs#395 (comment) ,
My local:
Passed with no errors.
Travis:
https://app.travis-ci.com/github/checkstyle/eclipse-cs/jobs/588314590#L625
Reasoning for issue can be found in #113 (comment)
The text was updated successfully, but these errors were encountered: