-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question/feature request] Allow slashes (/) in flag keys #315
Comments
I see, are you going to use |
Yeah, the plan is to encourage our users to namespace things in intelligent ways. Something like
or even
|
I'm working on the necessary change to this now - the simplest route is to change the regex to |
I think that's ok, people may like some file-path style if they choose to. |
Closed by #316 |
Expected Behavior
Flags with the
/
character should be able to be madeCurrent Behavior
util.IsSafeKey()
rejects flags with a slash due to thekeyRegex
defined as^[\w\d-]+$
Possible Solution
Change the regex to allow slashes
Context
Trying to namespace flags with slashes.
Question
Is there a technical reason for the lack of slashes here? If not, it should be a fairly innocuous change that I'd gladly put up a PR for
The text was updated successfully, but these errors were encountered: