dump: Show task comm early #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When error happens on file dumping stage the only information about the task we dumping is its PID. For debug purpose show task's @comm early. It proves useful when trying to understand which of dumped applications is "guilty" in brokern dump when pid is not there anymore. Signed-off-by: Cyrill Gorcunov <[email protected]> Signed-off-by: Pavel Tikhomirov <[email protected]>
Snorch
force-pushed
the
dump-show-task-comm-early
branch
from
49a176d to
36e4bd5
Compare
Codecov ReportBase: 70.92% // Head: 70.94% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2064 +/- ##
============================================
+ Coverage 70.92% 70.94% +0.02%
============================================
Files 132 133 +1
Lines 32620 32640 +20
============================================
+ Hits 23135 23156 +21
+ Misses 9485 9484 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adrianreber
approved these changes
Feb 26, 2023
avagin
reviewed
Feb 27, 2023
avagin
reviewed
Feb 27, 2023
avagin
reviewed
Feb 27, 2023
Snorch
added a commit
to Snorch/criu
that referenced
this pull request
Feb 27, 2023
This addresses Andrei comments from checkpoint-restore#2064 - Add comment about '\n' fixing - Replace ret with more self explainting is_read - Print warings if we failed to print comm for some reason Signed-off-by: Pavel Tikhomirov <[email protected]>
adrianreber
pushed a commit
that referenced
this pull request
Feb 28, 2023
This addresses Andrei comments from #2064 - Add comment about '\n' fixing - Replace ret with more self explainting is_read - Print warings if we failed to print comm for some reason Signed-off-by: Pavel Tikhomirov <[email protected]>
avagin
pushed a commit
to avagin/criu
that referenced
this pull request
Mar 13, 2023
This addresses Andrei comments from checkpoint-restore#2064 - Add comment about '\n' fixing - Replace ret with more self explainting is_read - Print warings if we failed to print comm for some reason Signed-off-by: Pavel Tikhomirov <[email protected]>
avagin
pushed a commit
that referenced
this pull request
Apr 16, 2023
This addresses Andrei comments from #2064 - Add comment about '\n' fixing - Replace ret with more self explainting is_read - Print warings if we failed to print comm for some reason Signed-off-by: Pavel Tikhomirov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When error happens on file dumping stage the only information about the task we dumping is its PID. For debug purpose show task's @comm early.
It proves useful when trying to understand which of dumped applications is "guilty" in brokern dump when pid is not there anymore.
Signed-off-by: Cyrill Gorcunov [email protected]
Signed-off-by: Pavel Tikhomirov [email protected]
--
This is a port of https://src.openvz.org/projects/OVZ/repos/criu/commits/487a62763
CC @cyrillos