Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty: Only store the stdin fd when it corresponds to a tty #1455

Open
wants to merge 2 commits into
base: criu-dev
Choose a base branch
from
Open

tty: Only store the stdin fd when it corresponds to a tty #1455

wants to merge 2 commits into from

Commits on Aug 28, 2023

  1. tty: Only store the stdin fd when it corresponds to a tty 

    Let's save some place in fdstore by not adding fd when it is unused.
Also let's remove now excess stdin_isatty.

Co-authored-by: Nicolas Viennot <[email protected]>
Signed-off-by: Pavel Tikhomirov <[email protected]>
    @nviennot @Snorch
    nviennot authored and Snorch committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8488934 View commit details
    Browse the repository at this point in the history

  2. files: prohibit --inherit-fd via std fds 

    Else inherit_fd_move_to_fdstore will close std fds and options like
--shell-job will be broken.

Signed-off-by: Pavel Tikhomirov <[email protected]>
    @Snorch
    Snorch committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1ed709c View commit details
    Browse the repository at this point in the history