Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

feat: able to specify custom key for input record #111

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

mikedidomizio
Copy link
Contributor

Pull Request Template

Description

Added the ability to change the keyboard command for recording input changes. By default this is TAB. There are a few closed issues that had discussion about how to remedy the tabbing and losing focus, but no solution.

This change allows users to change what key to finish input record to what they want. For instance I found SHIFT to be a better key.

This adds a button in the options menu, where a user clicks it and the extension listens for the next key down event.
I'm not a big fan of displaying the key code instead of the actual key but I didn't want to store both as one is only for display purposes.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
    This is up for debate, the documentation does mention the TAB key

How Has This Been Tested?

Ran the entire test suite that's provided and added unit tests to cover the new changes.

Checklist:

  • My code follows the style guidelines of this project. npm run lint passes with no errors.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. npm run test passes with no errors.

@tnolet
Copy link
Member

tnolet commented Oct 21, 2020

@mikedidomizio thanks for supplying this PR. We will review ASAP!

@maxigimenez
Copy link
Member

LGTM 👍 , thanks for contributing @mikedidomizio!

@maxigimenez maxigimenez merged commit 9e7a4b8 into checkly:master Oct 30, 2020
@mikedidomizio mikedidomizio deleted the change-key-code branch October 30, 2020 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants