This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
feat: able to specify custom key for input record #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Added the ability to change the keyboard command for recording input changes. By default this is TAB. There are a few closed issues that had discussion about how to remedy the tabbing and losing focus, but no solution.
This change allows users to change what key to finish input record to what they want. For instance I found SHIFT to be a better key.
This adds a button in the options menu, where a user clicks it and the extension listens for the next key down event.
I'm not a big fan of displaying the key code instead of the actual key but I didn't want to store both as one is only for display purposes.
Type of change
Please delete options that are not relevant.
This is up for debate, the documentation does mention the TAB key
How Has This Been Tested?
Ran the entire test suite that's provided and added unit tests to cover the new changes.
Checklist:
npm run lint
passes with no errors.npm run test
passes with no errors.