Use newer operator-sdk.

[AndrienkoAleksandr]

What does this pull request do:

Use newer operator-sdk(v1.7.1)
Use make for development. Most useful make commands you can find in the VSCode tasks.json.
For creation new release, can be used command 'make bundle-pre-release VERSION=0.0.10'. It should create new manifest package in the olm catalog.
Operator deployment for now consist of two containers: first one metrics container protected by auth proxy, and second one operator container. Also if operator was installed via OLM it should have Prometheus servicemonitor. I tested this stuf with prometheus operator. I configured in Prometeus CR service monitor selector to find operator service monitor by labels. After that Prometheus connected to the operator metrics. This metrics feature, that's a new stuff instead of removed

kubernetes-image-puller-operator/cmd/manager/main.go

Line 129 in 8561853

// addMetrics will create the Services and Service Monitors to allow the operator export the metrics by using

Removed stuff was actual only for older operator-sdk.

Referenced issue:

eclipse-che/che#20425
some initial part of the eclipse-che/che#20541

Related issue:

eclipse-che/che#20300

Signed-off-by: Oleksandr Andriienko [email protected]

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Click here to review and test in web IDE:

[AndrienkoAleksandr]

@ibuziuk, I updated image in the CR sample: used java11-maven=quay.io/eclipse/che-java11-maven:next instead of java11-maven=quay.io/eclipse/che-java11-maven:nightly, because this image is not present any more on the quay.io... By the way this removed image makes image-puller version 0.0.9 failing, if user used embedded sample to create CR.

[github-actions]

Click here to review and test in web IDE:

[ibuziuk]

By the way this removed image makes image-puller version 0.0.9 failing, if user used embedded sample to create CR.

thanks, actually we have the issue in the current sprint that is related to this problem - eclipse-che/che#20399

[github-actions]

Click here to review and test in web IDE:

[AndrienkoAleksandr]

@dkwon17 , thanks, I handled your feedback.

[dkwon17]

It would be great if we can also update the readme to mention version v1.7.1 instead of v0.19.4 (recommended):

kubernetes-image-puller-operator/README.md

Line 47 in d7f5f82

* Operator SDK `v0.19.4` (recommended)

and also update the commands:

kubernetes-image-puller-operator/README.md

Line 63 in d7f5f82

3. Run `operator-sdk generate k8s` and `operator-sdk generate crds --crd-version=v1`

kubernetes-image-puller-operator/README.md

Line 72 in d7f5f82

6. Copy the crd generated by `operator-sdk generate crds` into `deploy/olm-catalog/kubernetes-imagepuller-operator/VERSION`

[github-actions]

Click here to review and test in web IDE:

[AndrienkoAleksandr]

It would be great if we can also update the readme

Yes, I totally updated README file...

[AndrienkoAleksandr]

@dkwon17 , thanks, I think I handled your feedback.

[github-actions]

Click here to review and test in web IDE:

[AndrienkoAleksandr]

I updated description. This pr is also initial part of the work eclipse-che/che#20541 . But full migration to the new bundle format should be done separately after merge this pr and it is not urgent.

[tolusha]

@dkwon17
Could you approve pls?

[dkwon17]

Sorry for the delay, it seems I do not completely understand the bundle image format properly, but I am having trouble with the
Install operator via OLM task.

After running Build and push custom operator image and Build and push development bundle tasks, I ran the Install operator via OLM task to deploy on CRC.

I am getting this output from the task:

> Executing task: kubectl apply -f config/manager/controller-namespace.yaml; operator-sdk run bundle ${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/kubernetes-image-puller-operator-bundle:next --namespace ${NAMESPACE}; kubectl apply -f config/samples/che_v1alpha1_kubernetesimagepuller.yaml -n ${NAMESPACE} <

namespace/kubernetes-image-puller-operator unchanged
INFO[0016] Successfully created registry pod: quay-io-dkwon17-kubernetes-image-puller-operator-bundle-next 
INFO[0016] Created CatalogSource: kubernetes-imagepuller-operator-catalog 
INFO[0016] OperatorGroup "operator-sdk-og" created      
INFO[0016] Created Subscription: kubernetes-imagepuller-operator-v0-0-9-sub 
INFO[0032] Approved InstallPlan install-l2mkw for the Subscription: kubernetes-imagepuller-operator-v0-0-9-sub 
INFO[0032] Waiting for ClusterServiceVersion "kubernetes-image-puller-operator/kubernetes-imagepuller-operator.v0.0.9" to reach 'Succeeded' phase 
INFO[0032]   Waiting for ClusterServiceVersion "kubernetes-image-puller-operator/kubernetes-imagepuller-operator.v0.0.9" to appear 
INFO[0054]   Found ClusterServiceVersion "kubernetes-image-puller-operator/kubernetes-imagepuller-operator.v0.0.9" phase: Pending 
INFO[0057]   Found ClusterServiceVersion "kubernetes-image-puller-operator/kubernetes-imagepuller-operator.v0.0.9" phase: Installing 
FATA[0121] Failed to run bundle: error waiting for CSV to install: deployment kubernetes-image-puller-operator has error: context deadline exceeded
 
kubernetesimagepuller.che.eclipse.org/image-puller created

Containers in the kubernetes-image-puller-operator-7bfcd8b9d6-mbbzh pod:

Logs in kube-rbac-proxy:

I0928 14:08:33.027103       1 main.go:190] Valid token audiences:
I0928 14:08:33.027278       1 main.go:262] Generating self signed cert as no cert is provided
I0928 14:08:33.570558       1 main.go:311] Starting TCP socket on 0.0.0.0:8443
I0928 14:08:33.572245       1 main.go:318] Listening securely on 0.0.0.0:8443

Is this issue caused by the PR? I just wanted to address this, otherwise, this PR looks great.

[github-actions]

Click here to review and test in web IDE:

[AndrienkoAleksandr]

@dkwon17 thanks for feedback, fixed. Installation operator via OLM tasks should work.

[dkwon17]

Thank you for the updates, the PR works great. Please feel free to merge