Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prerequisites in csv #121

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Dec 21, 2023

I manually updated config/manifests/bases/kubernetes-image-puller-operator.clusterserviceversion.yaml and ran make bundle to generate the bundle/manifests/kubernetes-imagepuller-operator.clusterserviceversion.yaml

This PR is for updating the Prerequisites for enabling this Operator section on OperatorHub. Today (before this PR) it looks like this:

image

@dkwon17 dkwon17 requested a review from tolusha December 21, 2023 20:23
Copy link

Click here to review and test in web IDE: Contribute

Copy link

Click here to review and test in web IDE: Contribute

Copy link

Click here to review and test in web IDE: Contribute

@@ -362,4 +364,3 @@ spec:
targetPort: 9443
type: ValidatingAdmissionWebhook
webhookPath: /validate-che-eclipse-org-v1alpha1-kubernetesimagepuller
replaces: kubernetes-imagepuller-operator.v1.0.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns about this.

Copy link
Collaborator Author

@dkwon17 dkwon17 Dec 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed after make bundle, I've added it again in my new commit

Copy link

Click here to review and test in web IDE: Contribute

Copy link
Collaborator

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern that both OpenShift and Kubernetes bundles will have a reference to the cert-manager.

@dkwon17 dkwon17 force-pushed the update-description branch from 40540cc to 3e81300 Compare January 5, 2024 15:05
Copy link

github-actions bot commented Jan 5, 2024

Click here to review and test in web IDE: Contribute

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Jan 5, 2024

@tolusha that's a good point, I've updated the PR with:

Prerequisites for enabling this Operator

The operator requires an existing namespace to be installed in.
Check the README for more details.

WDYT?

@dkwon17 dkwon17 requested a review from ibuziuk January 8, 2024 14:28
@dkwon17 dkwon17 merged commit b4e00c7 into che-incubator:main Jan 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants