Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explictly specify microk8s.status output format #907

Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix: Explictly specify microk8s.status output format #907

merged 1 commit into from
Oct 7, 2020

Conversation

TheRealChssAddct
Copy link
Contributor

What does this PR do?

Explicitly specify microk8s.status output format (--format short) since microk8s recently changed the default format (with v 1.19.0), breaking the addons enabled preflight checks.

What issues does this PR fix or reference?

eclipse-che/che#16408

How to test this PR?

Using chectl with microk8s platform, where microk8s version is 1.19.0 or later, prior to fix, it will incorrectly fail on the MicroK8s preflight checklist, with the Error "The storage addon hasn't been enabled in microk8s".

After the fix, the preflight checks for storage and ingress addons enabled will succeed.

@openshift-ci-robot
Copy link
Collaborator

Hi @TheRealChssAddct. Thanks for your PR.

I'm waiting for a che-incubator member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TheRealChssAddct, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 4ecde0d into che-incubator:master Oct 7, 2020
@che-bot che-bot added this to the 7.20 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants