Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add flag to skip health check #685

Merged
merged 2 commits into from
May 5, 2020
Merged

feat: Add flag to skip health check #685

merged 2 commits into from
May 5, 2020

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented May 5, 2020

Signed-off-by: Anatoliy Bazko [email protected]

What does this PR do?

Add --skip-kubernetes-health-check flag to bypass k8s health check.

What issues does this PR fix or reference?

eclipse-che/che#15331

@tolusha
Add flag to skip health check
ac3cd1b 
Signed-off-by: Anatoliy Bazko <[email protected]>
@tolusha tolusha mentioned this pull request May 5, 2020
Closed
50 tasks
@tolusha tolusha changed the title Add flag to skip health check feat: Add flag to skip health check May 5, 2020
sleshchenko
sleshchenko approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to add a message to a place where we fail k8s health check:

if you're sure that your Kubernetes cluster is healthy - you may skip this check with  --skip-kubernetes-health-check flag

@tolusha
Improve error message
a211cee 
Signed-off-by: Anatoliy Bazko <[email protected]>
@tolusha
Copy link
Collaborator Author

tolusha commented May 5, 2020

[test]

@tolusha tolusha merged commit 9061410 into master May 5, 2020
@tolusha tolusha deleted the ab/skiphealthcheckflag branch May 5, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

@l0rd l0rd Awaiting requested review from l0rd

@mmorhun mmorhun Awaiting requested review from mmorhun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tolusha @sleshchenko